Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-fido2): Add test cases for RP domain origin. #10572

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

imran-ishaq
Copy link
Contributor

@imran-ishaq imran-ishaq commented Jan 8, 2025

…handle multiple origins #9248

Prepare


Description

Target issue

closes #9248

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jan 8, 2025
@imran-ishaq imran-ishaq marked this pull request as ready for review January 8, 2025 09:25
@imran-ishaq imran-ishaq requested a review from yurem as a code owner January 8, 2025 09:25
@imran-ishaq imran-ishaq requested a review from maduvena January 8, 2025 09:26
Copy link

sonarqubecloud bot commented Jan 8, 2025

@yurem yurem enabled auto-merge (squash) January 8, 2025 15:49
@yurem yurem merged commit 22f0cbe into main Jan 14, 2025
1 check passed
@yurem yurem deleted the jans-fido-add-test-case_9248 branch January 14, 2025 09:05
Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-fido2 Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProjectPasskeys: Replace requestedParties with rpId, and origins
5 participants