-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config-api): replacing testing framework to TestNG #10417
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: pujavs <[email protected]>
…ns-config-api-testng-9125_new
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
…ns-config-api-testng-9125_new
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
Signed-off-by: pujavs <[email protected]>
:wq! :wq! :wqMerge branch 'main' of https://github.com/JanssenProject/jans into jans-config-api-testng-9125_new
Signed-off-by: pujavs <[email protected]>
…ns-config-api-testng-9125_new
Signed-off-by: pujavs <[email protected]>
…ns-config-api-testng-9125_new
DryRun Security SummaryThe pull request focuses on updating the testing infrastructure for the Jans Config API project by replacing the Karate testing framework with TestNG, adding new test cases for various functionalities, and improving build and deployment configurations. Expand for full summarySummary: The code changes in this pull request span across multiple files and modules of the Jans Config API project, with a focus on updating the testing infrastructure and configuration. The key changes include:
From an application security perspective, the changes do not appear to introduce any immediate security vulnerabilities. However, it is important to review the actual implementation of the tested functionalities, as well as the test cases themselves, to ensure that proper security measures are in place, such as input validation, secure authentication and authorization, and proper handling of sensitive data. Additionally, the expansion of the OAuth2 scopes and the inclusion of custom test listeners should be closely examined to ensure that they do not inadvertently expose sensitive configuration settings or introduce potential privilege escalation vulnerabilities. Overall, the changes seem to be focused on improving the testing and deployment infrastructure of the Jans Config API project, which is a positive step towards ensuring the security and reliability of the application. Files Changed:
Code AnalysisWe ran
|
I am fixing Sonar reported issues |
Signed-off-by: pujavs <[email protected]>
Quality Gate failed for 'jans-config-api-parent'Failed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Signed-off-by: pujavs <[email protected]>
Signed-off-by: Yuriy Movchan <[email protected]>
Signed-off-by: Yuriy Movchan <[email protected]>
Signed-off-by: Yuriy Movchan <[email protected]>
…JanssenProject/jans into jans-config-api-testng-9125_new
Signed-off-by: Yuriy Movchan <[email protected]>
…ns-config-api-testng-9125_new
…JanssenProject/jans into jans-config-api-testng-9125_new
Quality Gate passed for 'agama parent'Issues Measures |
Quality Gate passed for 'jans-linux-setup'Issues Measures |
Quality Gate passed for 'Jans-Keycloak-Link'Issues Measures |
Quality Gate passed for 'SCIM API'Issues Measures |
Signed-off-by: pujavs <[email protected]>
…JanssenProject/jans into jans-config-api-testng-9125_new
Signed-off-by: pujavs <[email protected]>
Prepare
Description
9125: Replaced testing framework from Karate to TestNG
Target issue
closes #9125
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.