-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): remove spanner related documentation #10057
Conversation
Signed-off-by: ossdhaval <[email protected]>
Signed-off-by: ossdhaval <[email protected]>
Signed-off-by: ossdhaval <[email protected]>
DryRun Security SummaryThe pull request primarily focuses on the removal of support for the Google Cloud Spanner database in the Janssen Server project, which simplifies the deployment options, reduces the potential attack surface, and improves the security, maintainability, and configurability of the project. Expand for full summarySummary: The changes in this pull request primarily focus on the removal of support for the Google Cloud Spanner database in the Janssen Server project. This includes updates to the installation and configuration documentation, as well as the removal of Spanner-related files and references throughout the codebase. From an application security perspective, the removal of Spanner support is a positive change, as it simplifies the deployment options and reduces the potential attack surface by eliminating a relatively new and complex database service. The changes also include updates to the MySQL configuration documentation, which highlight the use of secure practices, such as password hashing and connection pool management. Additionally, the uninstallation process for the Janssen Server appears to be thorough, ensuring that all components and configuration files are properly removed. However, the handling of the persistence store during uninstallation should be further investigated to ensure that any sensitive data is properly managed and secured. Overall, the changes in this pull request seem to be focused on improving the security, maintainability, and configurability of the Janssen Server project, which is a positive step from an application security perspective. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Error: Hi @ossdhaval, You did not reference an open issue in your PR. I attempted to create an issue for you. |
Quality Gate passed for 'jans-pycloudlib'Issues Measures |
Please edit this.
Closes #10058,