Login signup feature #1
Conversation
JanakMistry2000
requested review from
AnkitSimform and
vatsaltanna-simformsolutions
lib/views/login_signup.dart
Outdated
|
|
||
| class login_signup_state extends State<login_signup>{ | ||
|
|
||
| TextEditingController _txt1 = TextEditingController(); |
There was a problem hiding this comment.
Variable names should always be meaningful.
lib/views/login_signup.dart
Outdated
| FocusNode contact = FocusNode(); | ||
| final _formKey = GlobalKey<FormState>(); | ||
| final _formKey2 = GlobalKey<FormState>(); | ||
| late double h1,h2,h3; // this will be used for setting margin over waves |
There was a problem hiding this comment.
This is not a good practice to name a variable. Variable names should always be meaningful.
lib/views/login_signup.dart
Outdated
| final _formKey = GlobalKey<FormState>(); | ||
| final _formKey2 = GlobalKey<FormState>(); | ||
| late double h1,h2,h3; // this will be used for setting margin over waves | ||
| bool first_pane= true,onstart=true,display_text=true;// true if first page is open, false if close. onstart is only set once |
There was a problem hiding this comment.
Please declare variables in the new line if you need to provide an initial value.
lib/views/login_signup.dart
Outdated
| return "Please enter an email id"; | ||
| } | ||
| String email_format = "[a-zA-Z0-9\+\.\_\%\-\+]{1,256}"+ //Regular Expression to match the email id | ||
| "\\@""[a-zA-Z0-9\\-]{0,64}"+ |
There was a problem hiding this comment.
Static strings should not be in the class. Create a separate category and declare all the static strings there.
lib/views/login_signup.dart
Outdated
| Expanded( | ||
| child: AnimatedContainer( | ||
| margin: EdgeInsets.fromLTRB(0, h1, 0, 0), | ||
| //height: 500, |
There was a problem hiding this comment.
Commented code should not be in commit.
lib/views/login_signup.dart
Outdated
| ), | ||
| Padding( | ||
| padding: const EdgeInsets.all(15.0), | ||
| child: Text("WELCOME!",style: TextStyle(color: Colors.white,fontSize: 35),), |
There was a problem hiding this comment.
Formate this file properly.
lib/views/login_signup.dart
Outdated
| ), | ||
| style: TextStyle(color: Colors.white), | ||
| ), | ||
| const SizedBox(height: 50,), |
There was a problem hiding this comment.
Please do not use the coma at the last parameter when there are two or less than two parameters.
lib/views/login_signup.dart
Outdated
| borderSide: BorderSide(color: Colors.white), | ||
| ), | ||
| hintStyle: TextStyle(color: Colors.grey[400]), | ||
| suffixIcon: IconButton(onPressed: _pass_vis, icon: Icon(Icons.remove_red_eye),color: Colors.white,), |
There was a problem hiding this comment.
Please formate the class properly.
lib/views/login_signup.dart
Outdated
| } | ||
| } | ||
|
|
||
| class draw_curve extends CustomPainter{ |
There was a problem hiding this comment.
Create a separate file for a new class.
Signup Module
This project is a for sign-up module for Ch-4 Flutter basics Practical.
Dart Version
Screenshot
Design Inspiration
This design of login and sign up module is inspired from this https://www.studioamigos.com/login-animation-studio/