Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility fix for PHP 5.3 #435

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

StudioMaX
Copy link
Collaborator

Array dereferencing support was added only with PHP 5.4

@StudioMaX StudioMaX marked this pull request as ready for review February 1, 2024 16:17
@JamesHeinrich JamesHeinrich merged commit 3bcea90 into JamesHeinrich:master Feb 1, 2024
14 checks passed
@JamesHeinrich
Copy link
Owner

Thanks. How long should we care about PHP5 compatibility? PHP7 has been out for 8 years now.

@StudioMaX
Copy link
Collaborator Author

The main problem is that in order to at least partially comply with the semver, we cannot remove unsupported PHP versions in the current major version; for this we will need to release a new major or at least 1.10 version. In 2.0 and my local 2.1, I long ago bumped the minimum version to PHP 7.2, but I can’t find the time to finalize 2.1 to a working state, I’m just merging all new commits from 1.9. :)

@StudioMaX StudioMaX deleted the php53fix branch February 1, 2024 17:07
@JamesHeinrich
Copy link
Owner

Whenever you're ready for 2.1 I can also increment to 1.10 and match your minimum PHP version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants