Small fix for type checking with pyright #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type checker that is included with Visual Studio Code (pyright) will only resolve imports in the try branch of a try-except statement. This means that VSPresetVideoFormat won't be resolved if your typing stubs are up-to-date, as the correct import is in the except branch. Swapping the try and except branches makes it work with freshly generated stubs, but will break older ones. However, since there is (seemingly) no way to make it work with both, having newer ones work seems like the better compromise to me.
LightArrowsEXE
merged commit fbfcc6b
into
Jaded-Encoding-Thaumaturgy:master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type checker that is included with Visual Studio Code (pyright) will only resolve imports in the try branch of a try-except statement.
This means that VSPresetVideoFormat won't be resolved if your typing stubs are up-to-date, as the correct import is in the except branch.
Swapping the try and except branches makes it work with freshly generated stubs, but will break older ones. However, since there is (seemingly) no way to make it work with both, having newer ones work seems like the better compromise to me.