Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ridgemask #30

Merged

Conversation

Ichunjo
Copy link

@Ichunjo Ichunjo commented Nov 18, 2024

  • Integer clips have wrong output so the processing is now always in 32-bit float
  • xy derivative was wrong (it didn't affect the output much)
  • The expr was missing a 0.5 factor. Output will be different and is a breaking change.
  • 5x5 convolutions need a right border fix. Technically, we only need 2 pixels but you'd have to fix each derivative and it slows down the process by quite a bit. Adding a 4 px mirror border and cropping it at the end is close enough.

@emotion3459 emotion3459 merged commit 418eab4 into Jaded-Encoding-Thaumaturgy:master Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants