Assignment-2 #5
Open
Assignment-2 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uploaded only the modified src files and renders folder containing rendered images. |
ereator
reviewed
Nov 23, 2020
| @@ -77,7 +93,7 @@ class CScene | |||
| bool occluded(Ray& ray) | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| return false; | |||
| return intersect(ray); | |||
There was a problem hiding this comment.
Might be optimized here...
| */ | ||
| for (auto i = m_vpPrims.begin(); i != m_vpPrims.end(); i++) { | ||
| if ((*i)->intersect(ray)) { | ||
| return true; |
There was a problem hiding this comment.
you exit the method once the first intersection was found - but you need to find the nearest one!
| Vec3f direction = m_org - ray.org; | ||
| Vec3f intensity = m_intensity / pow(cv::norm(direction), 2); | ||
| ray.dir = normalize(direction); | ||
| return normalize(intensity); |
There was a problem hiding this comment.
Intensity should not be normalized...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.