Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tamagotchi_shop #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tamagotchi_shop #6

wants to merge 2 commits into from

Conversation

Jackliu-miaozi
Copy link
Owner

No description provided.

shamilsan
shamilsan approved these changes Dec 18, 2023
View reviewed changes
Copy link

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

But some tests would be appreciated.

contracts/04-tamagotchi-shop/src/lib.rs Outdated
Comment on lines 27 to 30
pub type TransactionId = u64;
pub type AttributeId = u32;
pub type Price = u128;
pub type TamagotchiId = ActorId;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to double the code. It is better to reuse it from the io crate.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got.

@Jackliu-miaozi
Copy link
Owner Author

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamilsan shamilsan shamilsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jackliu-miaozi @shamilsan