Tamagotchi_nft #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilsan
approved these changes
Dec 15, 2023
| .payload(TmgEvent::Transferred(1.into())); | ||
| assert!(result.contains(&log)); | ||
|
|
||
| // let result = program.send(1, TmgAction::Approve(2.into())); |
There was a problem hiding this comment.
Need to check the transfer from approved and not approved accounts.
There was a problem hiding this comment.
Why am I unable to pass the test?
| .expect("Error in a reply'tamagotchi::approval_revoked'"); | ||
| } | ||
| } | ||
| } else if msg::source() == tmg.approved_account.unwrap_or_default() { |
There was a problem hiding this comment.
Better would be better to check the account permissions inside the TmgAction::Transfer branch to not double the code.
Also, it is better to not call msg::source twice.
| @@ -129,6 +131,32 @@ extern fn handle() { | |||
| msg::reply(TmgEvent::Slept, 1).expect("Error in a reply'tamagotchi::slept'"); | |||
| } | |||
| } | |||
| TmgAction::Transfer(account) => { | |||
| tmg.owner = account; | |||
There was a problem hiding this comment.
One should reset the approved_account after transferring the ownership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.