-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Checkstyle settings for newline after catch brace #12189
Conversation
"Test failed successfully" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
Ah, perfect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
Seems to work, but would be even better if we could get this fixed in IJ |
Yes, the auto formatting. Takes some "minutes" to experiment / google / check intellij issues / report intellij issue / ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
For completeness, I would like to see a link to an stackoverflow question having this as question - and posting this as answer maybe? |
Clarifying - This as answer - you mean the checkstyle properties in this PR as the answer? |
Fixed the violations in the rest of the codebase. Tests will be green now. Can do a final review and merge. |
Question: Title: "How can checkstyle be configured to throw an error if a line break is after the opening brace" Example: I have try {
// ...
} catch (
Exception e) {
// ...
} Then you can also do "answer your own question". - Or wait for 48h if someone else answers |
Since this has been troubling for a while now...
IntelliJ:
This PR should test for github actions and reviewdog before merge.
Mandatory checks
Change inCHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)Tests created for changes (if applicable)