Added keybinding for renaming group with F2

src/main/java/org/jabref/gui/actions/StandardActions.java

@@ -192,6 +192,7 @@ public enum StandardActions implements Action {
     GROUP_REMOVE_KEEP_SUBGROUPS(Localization.lang("Keep subgroups")),
     GROUP_REMOVE_WITH_SUBGROUPS(Localization.lang("Also remove subgroups")),
     GROUP_CHAT(Localization.lang("Chat with group")),
+    GROUP_RENAME(Localization.lang("Rename group"),KeyBinding.RENAME_GROUP),
     GROUP_EDIT(Localization.lang("Edit group")),
     GROUP_GENERATE_SUMMARIES(Localization.lang("Generate summaries for entries in the group")),
     GROUP_GENERATE_EMBEDDINGS(Localization.lang("Generate embeddings for linked files in the group")),

src/main/java/org/jabref/gui/groups/GroupDialogView.java

@@ -118,6 +118,7 @@ public GroupDialogView(BibDatabaseContext currentDatabase,
                            @Nullable GroupTreeNode parentNode,
                            @Nullable AbstractGroup editedGroup,
                            GroupDialogHeader groupDialogHeader) {
+
         this.currentDatabase = currentDatabase;
         this.parentNode = parentNode;
         this.editedGroup = editedGroup;
@@ -158,6 +159,8 @@ public GroupDialogView(BibDatabaseContext currentDatabase,
         confirmDialogButton.disableProperty().bind(viewModel.validationStatus().validProperty().not());
         // handle validation before closing dialog and calling resultConverter
         confirmDialogButton.addEventFilter(ActionEvent.ACTION, viewModel::validationHandler);
+
+
     }
 
     private @Nullable AbstractGroup parentGroup() {

src/main/java/org/jabref/gui/groups/GroupTreeView.java

@@ -10,6 +10,11 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.stream.Collectors;
+import javafx.scene.control.ContextMenu;
+import javafx.scene.control.MenuItem;
+import javafx.scene.control.Button;
+import javafx.scene.layout.BorderPane;
+import javafx.scene.layout.HBox;
 
 import javafx.application.Platform;
 import javafx.beans.binding.Bindings;
@@ -538,6 +543,7 @@ private ContextMenu createContextMenuForGroup(GroupNodeViewModel group) {
         ActionFactory factory = new ActionFactory();
 
         MenuItem removeGroup;
+
         if (group.hasSubgroups() && group.canAddGroupsIn() && !group.isRoot()) {
             removeGroup = new Menu(Localization.lang("Remove group"), null,
                     factory.createMenuItem(StandardActions.GROUP_REMOVE_KEEP_SUBGROUPS,
@@ -557,6 +563,7 @@ private ContextMenu createContextMenuForGroup(GroupNodeViewModel group) {
                 factory.createMenuItem(StandardActions.GROUP_EDIT, new ContextAction(StandardActions.GROUP_EDIT, group)),
                 factory.createMenuItem(StandardActions.GROUP_GENERATE_EMBEDDINGS, new ContextAction(StandardActions.GROUP_GENERATE_EMBEDDINGS, group)),
                 factory.createMenuItem(StandardActions.GROUP_GENERATE_SUMMARIES, new ContextAction(StandardActions.GROUP_GENERATE_SUMMARIES, group)),
+                factory.createMenuItem(StandardActions.GROUP_RENAME, new ContextAction(StandardActions.GROUP_RENAME, group)),
                 removeGroup,
                 new SeparatorMenuItem(),
                 factory.createMenuItem(StandardActions.GROUP_SUBGROUP_ADD, new ContextAction(StandardActions.GROUP_SUBGROUP_ADD, group)),
@@ -639,6 +646,8 @@ public ContextAction(StandardActions command, GroupNodeViewModel group) {
                     switch (command) {
                         case GROUP_EDIT ->
                                 group.isEditable();
+                        case GROUP_RENAME ->
+                                group.isEditable();
                         case GROUP_REMOVE, GROUP_REMOVE_WITH_SUBGROUPS, GROUP_REMOVE_KEEP_SUBGROUPS ->
                                 group.isEditable() && group.canRemove();
                         case GROUP_SUBGROUP_ADD ->
@@ -662,6 +671,9 @@ public void execute() {
             switch (command) {
                 case GROUP_REMOVE ->
                         viewModel.removeGroupNoSubgroups(group);
+                case GROUP_RENAME -> {
+                    viewModel.renameGroup(group);
+                }
                 case GROUP_REMOVE_KEEP_SUBGROUPS ->
                         viewModel.removeGroupKeepSubgroups(group);
                 case GROUP_REMOVE_WITH_SUBGROUPS ->

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

@@ -260,9 +260,68 @@ boolean onlyMinorChanges(AbstractGroup oldGroup, AbstractGroup newGroup) {
         return true;
     }
 
+    /**
+     * Opens "Rename Group Dialog" and change name of group
+     */
+
+    public void renameGroup(GroupNodeViewModel oldGroup) {
+        currentDatabase.ifPresent(database -> {
+            AbstractGroup oldGroupDef = oldGroup.getGroupNode().getGroup();
+            String oldGroupName = oldGroupDef.getName(); // Zachytenie starého názvu pred otvorením dialógu
+
+
+            Optional<AbstractGroup> newGroup = dialogService.showCustomDialogAndWait(
+                    new RenameGroupView(database,
+                            oldGroup.getGroupNode().getGroup())
+            );
+
+            newGroup.ifPresent(group -> {
+
+                String newGroupName = group.getName();
+
+
+                //check if it´s empty new string
+                if (newGroupName.trim().isEmpty()) {
+                    dialogService.notify(Localization.lang("The new group name cannot be empty or consist only of spaces."));
+                    return;
+                }
+
+                // check if is not include ","
+                if (newGroupName.contains(",")) {
+                    dialogService.notify(Localization.lang("The new group name cannot contain commas."));
+                    return;
+                }
+
+                // chceck if old group name dont equels with new group name
+                if (oldGroupName.equals(newGroupName)) {
+                    dialogService.notify(Localization.lang("The new group name is the same as the old one. No changes made."));
+                    return;
+                }
+
+
+                // check if other groups name are not same
+                int groupsWithSameName = 0;
+                Optional<GroupTreeNode> databaseRootGroup = currentDatabase.get().getMetaData().getGroups();
+                if (databaseRootGroup.isPresent()) {
+                    groupsWithSameName = databaseRootGroup.get().findChildrenSatisfying(g -> g.getName().equals(newGroupName)).size();
+                }
+
+                // then change name
+                if (groupsWithSameName < 2) {
+                    oldGroup.getGroupNode().setGroup(group, true, true, database.getEntries());
+                    dialogService.notify(Localization.lang("Renamed group from \"%0\" to \"%1\".", oldGroupName, newGroupName));
+                    writeGroupChangesToMetaData();
+                    refresh();
+                }
+            });
+        });
+    }
+
+
     /**
      * Opens "Edit Group Dialog" and changes the given group to the edited one.
      */
+
     public void editGroup(GroupNodeViewModel oldGroup) {
         currentDatabase.ifPresent(database -> {
             Optional<AbstractGroup> newGroup = dialogService.showCustomDialogAndWait(new GroupDialogView(

src/main/java/org/jabref/gui/groups/RenameGroupView.java

@@ -0,0 +1,83 @@
+package org.jabref.gui.groups;
+
+import jakarta.inject.Inject;
+import javafx.fxml.FXML;
+import javafx.scene.control.*;
+import javafx.scene.layout.VBox;
+import org.jabref.gui.DialogService;
+import org.jabref.gui.util.BaseDialog;
+import org.jabref.logic.l10n.Localization;
+import org.jabref.model.database.BibDatabaseContext;
+import org.jabref.model.groups.*;
+import org.jspecify.annotations.Nullable;
+
+import java.util.Optional;
+
+public class RenameGroupView extends BaseDialog<AbstractGroup> {
+
+    @FXML
+    private TextField nameField;
+
+    @Inject
+    private DialogService dialogService;
+
+
+    private final BibDatabaseContext currentDatabase;
+    private final @Nullable AbstractGroup editedGroup;
+
+    public RenameGroupView(BibDatabaseContext currentDatabase,
+                           @Nullable AbstractGroup editedGroup) {
+        this.currentDatabase = currentDatabase;
+        this.editedGroup = editedGroup;
+
+        // set Width and Height
+        setWidth(400);
+        setHeight(150);
+
+        // set Title name
+        setTitle(Localization.lang("Rename group"));
+
+        // add OK and Cancel buttons
+        getDialogPane().getButtonTypes().setAll(ButtonType.OK, ButtonType.CANCEL);
+
+        nameField = new TextField();
+        nameField.setPromptText("Enter new group name");
+
+        // add Input
+        VBox vbox = new VBox(new Label("New group name:"), nameField);
+        getDialogPane().setContent(vbox);
+
+        // If press OK change name else return null
+        setResultConverter(buttonType -> {
+            if (buttonType == ButtonType.OK) {
+                return resultConverter(ButtonType.OK).orElse(null);
+            } else {
+                // Ak sa zvolí Cancel alebo sa dialóg zavrie cez X
+                return null;
+            }
+        });
+    }
+
+    protected Optional<AbstractGroup> resultConverter(ButtonType button) {
+        if (button != ButtonType.OK) {
+            return Optional.empty();
+        }
+
+        try {
+            // Get new name from Input
+            String newGroupName = nameField.getText().trim();
+
+            if (editedGroup != null) {
+                //set new input
+                editedGroup.nameProperty().set(newGroupName);
+                return Optional.of(editedGroup);
+            }
+
+            return Optional.empty();
+        } catch (Exception exception) {
+            dialogService.showErrorDialogAndWait(exception.getLocalizedMessage(), exception);
+            return Optional.empty();
+        }
+    }
+}
+

src/main/java/org/jabref/gui/keyboard/KeyBinding.java

@@ -6,7 +6,8 @@
  * @implNote Cannot be sorted alphabetically, as {@link KeyBindingRepository#getKeyCombination(KeyBinding)} iterates over the enum in order and returns the first match.
  */
 public enum KeyBinding {
-    EDITOR_DELETE("Delete", Localization.lang("Delete text"), "", KeyBindingCategory.EDITOR),
+    EDITOR_DELETE("Delete", Localization.lang("Delete text"), "",KeyBindingCategory.EDITOR ),
+    RENAME_GROUP("Rename Group",Localization.lang("Rename group"),"R", KeyBindingCategory.EDIT),
     // DELETE BACKWARDS = Rubout
     EDITOR_BACKWARD("Move caret left", Localization.lang("Move caret left"), "", KeyBindingCategory.EDITOR),
     EDITOR_FORWARD("Move caret right", Localization.lang("Move caret right"), "", KeyBindingCategory.EDITOR),