Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @deprecated by explaining text #12055

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Replace @deprecated by explaining text #12055

merged 1 commit into from
Oct 21, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 21, 2024

Some @deprecated annotations were confusing. I replaced them with text.

Refs #11674

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor requested a review from calixtus October 21, 2024 18:27
@koppor koppor added the type: code-quality Issues related to code or architecture decisions label Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit a6db811 Oct 21, 2024
28 checks passed
@Siedlerchr Siedlerchr deleted the fix-deprecation branch October 21, 2024 20:50
@calixtus
Copy link
Member

Why remove deprecated? Adding the comment is fine, but deprecated does imho mean exactly what you are now describing. In other places you added annotations because of that.

@koppor koppor mentioned this pull request Oct 22, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants