Double click on citation opens LaTeX editor

.github/workflows/on-review-submitted.yml

@@ -0,0 +1,21 @@
+name: On reviewed PR
+
+on:
+  pull_request_review:
+     types:
+       - submitted
+
+jobs:
+  add-label-changes-required:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+      - run: echo ${{ github.event.review.state }}
+      - if: ${{ github.event.review.state == 'changes_requested' }}
+        run: |
+          gh pr edit "$PR_URL" --remove-label "status: ready-for-review"
+          gh pr edit "$PR_URL" --add-label "status: changes required"
+        env:
+          PR_URL: ${{github.event.pull_request.html_url}}
+          GH_TOKEN: ${{ github.token }}

src/main/java/org/jabref/gui/entryeditor/LatexCitationsTab.java

@@ -59,6 +59,7 @@ private void setSearchPane() {
         citationsDisplay.basePathProperty().bindBidirectional(viewModel.directoryProperty());
         citationsDisplay.setItems(viewModel.getCitationList());
 
+        citationsDisplay.setOnMouseClicked(event -> viewModel.handleMouseClick(event, citationsDisplay));
         RowConstraints mainRow = new RowConstraints();
         mainRow.setVgrow(Priority.ALWAYS);
 

src/main/java/org/jabref/gui/entryeditor/LatexCitationsTabViewModel.java

@@ -15,10 +15,16 @@
 import javafx.beans.property.StringProperty;
 import javafx.collections.FXCollections;
 import javafx.collections.ObservableList;
+import javafx.scene.input.MouseButton;
+import javafx.scene.input.MouseEvent;
 
 import org.jabref.gui.AbstractViewModel;
 import org.jabref.gui.DialogService;
 import org.jabref.gui.preferences.GuiPreferences;
+import org.jabref.gui.push.PushToApplication;
+import org.jabref.gui.push.PushToApplications;
+import org.jabref.gui.push.PushToEmacs;
+import org.jabref.gui.texparser.CitationsDisplay;
 import org.jabref.gui.util.DirectoryDialogConfiguration;
 import org.jabref.gui.util.UiTaskExecutor;
 import org.jabref.logic.l10n.Localization;
@@ -154,6 +160,22 @@ public void onDirectoryDelete(File directory) {
         };
     }
 
+    public void handleMouseClick(MouseEvent event, CitationsDisplay citationsDisplay) {
+        Citation selectedItem = citationsDisplay.getSelectionModel().getSelectedItem();
+
+        if (event.getButton() == MouseButton.PRIMARY && event.getClickCount() == 2 && selectedItem != null) {
+            String applicationName = preferences.getPushToApplicationPreferences()
+                                                .getActiveApplicationName();
+            PushToApplication application = PushToApplications.getApplicationByName(
+                                                                      applicationName,
+                                                                      dialogService,
+                                                                      preferences)
+                                                              .orElse(new PushToEmacs(dialogService, preferences));
+            preferences.getPushToApplicationPreferences().setActiveApplicationName(application.getDisplayName());
+            application.jumpToLine(selectedItem.path(), selectedItem.line(), selectedItem.colStart());
+        }
+    }
+
     public void bindToEntry(BibEntry entry) {
         checkAndUpdateDirectory();
 

src/main/java/org/jabref/gui/push/AbstractPushToApplication.java

@@ -1,6 +1,7 @@
 package org.jabref.gui.push;
 
 import java.io.IOException;
+import java.nio.file.Path;
 import java.util.List;
 import java.util.Optional;
 
@@ -181,4 +182,28 @@ public Optional<KeyBinding> getKeyBinding() {
             return Optional.of(KeyBinding.PUSH_TO_APPLICATION);
         }
     }
+
+    public void jumpToLine(Path fileName, int line, int column) {
+        commandPath = preferences.getPushToApplicationPreferences().getCommandPaths().get(this.getDisplayName());
+
+        if (StringUtil.isNullOrEmpty(commandPath)) {
+            notDefined = true;
+            return;
+        }
+
+        String[] command = jumpString(fileName, line, column);
+        ProcessBuilder processBuilder = new ProcessBuilder();
+        try {
+            processBuilder.command(command);
+            processBuilder.start();
+        } catch (IOException excep) {
+            LOGGER.warn("Error: Could not call executable '{}'", commandPath, excep);
+            couldNotCall = true;
+        }
+    }
+
+    protected String[] jumpString(Path fileName, int line, int column) {
+        LOGGER.error("Not yet implemented");
+        return new String[0];
+    }
 }

src/main/java/org/jabref/gui/push/PushToApplication.java

@@ -1,5 +1,6 @@
 package org.jabref.gui.push;
 
+import java.nio.file.Path;
 import java.util.List;
 
 import org.jabref.gui.actions.Action;
@@ -56,4 +57,6 @@ public interface PushToApplication {
     PushToApplicationSettings getSettings(PushToApplication application, PushToApplicationPreferences pushToApplicationPreferences);
 
     String getDelimiter();
+
+    void jumpToLine(Path fileName, int line, int column);
 }

src/main/java/org/jabref/gui/push/PushToApplicationCommand.java

@@ -104,7 +104,7 @@ private static String getKeyString(List<BibEntry> entries, String delimiter) {
         for (BibEntry bes : entries) {
             citeKey = bes.getCitationKey();
             if (citeKey.isEmpty() || citeKey.get().isEmpty()) {
-                // Should never occur, because we made sure that all entries have keys
+                LOGGER.warn("Should never occur, because we made sure that all entries have keys");
                 continue;
             }
             if (first) {

src/main/java/org/jabref/gui/push/PushToEmacs.java

@@ -2,6 +2,7 @@
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.file.Path;
 import java.util.Arrays;
 import java.util.List;
 
@@ -147,4 +148,9 @@ protected String getCommandName() {
     public PushToApplicationSettings getSettings(PushToApplication application, PushToApplicationPreferences preferences) {
         return new PushToEmacsSettings(application, dialogService, this.preferences.getFilePreferences(), preferences);
     }
+
+    @Override
+    protected String[] jumpString(Path fileName, int line, int column) {
+        return new String[] {commandPath, "+%s".formatted(line), fileName.toString()};
+    }
 }

src/main/java/org/jabref/gui/push/PushToLyx.java

@@ -5,6 +5,7 @@
 import java.io.FileWriter;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Path;
 import java.util.List;
 
 import org.jabref.gui.DialogService;
@@ -95,4 +96,10 @@ public void pushEntries(BibDatabaseContext database, final List<BibEntry> entrie
             }
         });
     }
+
+    @Override
+    protected String[] jumpString(Path fileName, int line, int column) {
+        LOGGER.warn("not implemented");
+        return new String[0];
+    }
 }

src/main/java/org/jabref/gui/push/PushToSublimeText.java

@@ -86,4 +86,9 @@ protected String[] getCommandLine(String keyString) {
             return new String[] {"sh", "-c", "\"" + commandPath + "\"" + " --command 'insert {\"characters\": \"" + citeCommand + keyString + getCiteSuffix() + "\"}'"};
         }
     }
+
+    @Override
+    protected String[] jumpString(Path fileName, int line, int column) {
+        return new String[] {commandPath, "%s:%s:%s".formatted(fileName.toString(), line, column)};
+    }
 }

src/main/java/org/jabref/gui/push/PushToTeXstudio.java

@@ -1,5 +1,7 @@
 package org.jabref.gui.push;
 
+import java.nio.file.Path;
+
 import org.jabref.gui.DialogService;
 import org.jabref.gui.icon.IconTheme;
 import org.jabref.gui.icon.JabRefIcon;
@@ -27,4 +29,10 @@ public JabRefIcon getApplicationIcon() {
     protected String[] getCommandLine(String keyString) {
         return new String[] {commandPath, "--insert-cite", "%s%s%s".formatted(getCitePrefix(), keyString, getCiteSuffix())};
     }
+
+    @Override
+    public String[] jumpString(Path fileName, int line, int column) {
+        // Construct the TeXstudio command
+        return new String[] {commandPath, "--line", Integer.toString(line), fileName.toString()};
+    }
 }

src/main/java/org/jabref/gui/push/PushToTeXworks.java

@@ -1,5 +1,7 @@
 package org.jabref.gui.push;
 
+import java.nio.file.Path;
+
 import org.jabref.gui.DialogService;
 import org.jabref.gui.icon.IconTheme;
 import org.jabref.gui.icon.JabRefIcon;
@@ -33,4 +35,10 @@ public JabRefIcon getApplicationIcon() {
     protected String[] getCommandLine(String keyString) {
         return new String[] {commandPath, "--insert-text", "%s%s%s".formatted(getCitePrefix(), keyString, getCiteSuffix())};
     }
+
+    @Override
+    protected String[] jumpString(Path fileName, int line, int column) {
+        // didn't find any command to jump to a specific line
+        return new String[] {commandPath, fileName.toString()};
+    }
 }

src/main/java/org/jabref/gui/push/PushToTexmaker.java

@@ -1,5 +1,7 @@
 package org.jabref.gui.push;
 
+import java.nio.file.Path;
+
 import org.jabref.gui.DialogService;
 import org.jabref.gui.icon.IconTheme;
 import org.jabref.gui.icon.JabRefIcon;
@@ -30,4 +32,9 @@ public JabRefIcon getApplicationIcon() {
     protected String[] getCommandLine(String keyString) {
         return new String[] {commandPath, "-insert", getCitePrefix() + keyString + getCiteSuffix()};
     }
+
+    @Override
+    protected String[] jumpString(Path fileName, int line, int column) {
+        return new String[] {commandPath, "-line", Integer.toString(line), fileName.toString()};
+    }
 }