Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RFC links in Quick Import functionality (#11949) #12043

Merged
merged 19 commits into from
Oct 23, 2024
Merged

Support RFC links in Quick Import functionality (#11949) #12043

merged 19 commits into from
Oct 23, 2024

Commits on Oct 20, 2024

  1. Add RfcId to handle RFC url link to support quick import

    @ChengPuPu
    ChengPuPu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1672342 View commit details
    Browse the repository at this point in the history

  2. Refactor RFC URL parsing 

    Add JavaDoc comments
Remove unnecessary lowercase
    @ChengPuPu
    ChengPuPu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    365e50a View commit details
    Browse the repository at this point in the history

  3. Refactor RFC URL parsing 

    Add JavaDoc comments
Remove unnecessary lowercase
    @ChengPuPu
    ChengPuPu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f24ec13 View commit details
    Browse the repository at this point in the history

  4. Adjust code style

    @ChengPuPu
    ChengPuPu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    401f8ce View commit details
    Browse the repository at this point in the history

  5. Adjust code style

    @ChengPuPu
    ChengPuPu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    ddadb92 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into Issue11949-quick-import-for-RFC-link

    @AU0430
    AU0430 authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    787dc35 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. According to CI test feedback: 

    - Removed RFC entry from identifier list(StandardField.java)
- Modified RfcId class to extend EprintIdentifier
    @ChengPuPu
    ChengPuPu committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    11a57f1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/Issue11949-quick-import-for-RFC-… 

    …link' into Issue11949-quick-import-for-RFC-link
    @ChengPuPu
    ChengPuPu committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0649019 View commit details
    Browse the repository at this point in the history

  3. Accorfing to maintainer feedback to fix: 

    - Replaced RfcId name with RFC class for consistency and clarity.
- Updated RFC parsing logic to support both plain RFC IDs (e.g., "rfc7276") and full URLs (e.g., "https://www.rfc-editor.org/rfc/rfc7276.html").
- Added tests in RFCTest to validate proper parsing of RFC identifiers from both formats.
- Removed unnecessary method (isValid) improved code clarity.
- Adjusted the CompositeIdFetcher to integrate the new RFC class functionalities.
    @ChengPuPu
    ChengPuPu committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bc78c9c View commit details
    Browse the repository at this point in the history

  4. Refactored RFCTest to adhere to the suggestions provided: 

    - Converted `testParsePlainRfcId` to a `@ParameterizedTest` using `@CsvSource`.
- Adjusted `testInvalidRfc` to use `assertEquals(Optional.empty(), rfc)`.
- Updated `testGetExternalUri` to verify the URI using `Optional.of()` for consistent checks.
    @ChengPuPu
    ChengPuPu committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2c16f73 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into Issue11949-quick-import-for-RFC-link

    @AU0430
    AU0430 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    74ed902 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. adjust code format according to CI test(checkstyle)

    @ChengPuPu
    ChengPuPu committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d7300a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Issue11949-quick-import-for-RFC-link

    @AU0430
    AU0430 authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    846e64b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge remote-tracking branch 'origin/main' into Issue11949-quick-impo… 

    …rt-for-RFC-link
    @koppor
    koppor committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    90d769c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into Issue11949-quick-impo… 

    …rt-for-RFC-link
    @koppor
    koppor committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    03f7ea0 View commit details
    Browse the repository at this point in the history

  3. Swap expected and input

    @koppor
    koppor committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e0abc10 View commit details
    Browse the repository at this point in the history

  4. Fix OpenRewrite issues

    @koppor
    koppor committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    29a3e5e View commit details
    Browse the repository at this point in the history

  5. fix code style according to checkstyle

    @ChengPuPu
    ChengPuPu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    891e1f5 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/Issue11949-quick-import-for-RFC-… 

    …link' into Issue11949-quick-import-for-RFC-link
    @ChengPuPu
    ChengPuPu committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    98e4414 View commit details
    Browse the repository at this point in the history