Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement Id to ui-recommendations.md #11906

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Add requirement Id to ui-recommendations.md #11906

merged 5 commits into from
Oct 11, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 10, 2024

I am trying to give Ids to our important requirements. Background: https://devdocs.jabref.org/requirements/

This is for preparing to make https://github.com/JabRef/jabref-issue-melting-pot/issues/465 public.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Collaborator

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: use uniform tense

docs/code-howtos/ui-recommendations.md Outdated Show resolved Hide resolved
subhramit
subhramit previously approved these changes Oct 10, 2024
@subhramit subhramit added this pull request to the merge queue Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit f534dc5 Oct 11, 2024
28 of 31 checks passed
@subhramit subhramit deleted the requirements branch October 11, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants