added support for intercepting methods that return IAsyncEnumerable #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello JSkimming,
Here is a 1st implementation of adding support to IAsyncInterceptor in order to support mehods that return
IAsyncEnumerable<>Note that:
I have NOT implemented support in AsyncInterceptorBase, because I am not certain about what should be done in that case... (simply call
InterceptAsync<T>? Add a new abstract method in AsyncInterceptorBase?)I have implemented only a few unit tests, nothing concerning exception handling.
For now, it is more a "proof of concept" that anything else.
PS : I had to remove support for net45, because it does not support IAsyncEnumerable