Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fixes for issues #22, #20, and #19 #23

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

mikednjoy
Copy link

see discord for like nine paragraphs

mikednjoy and others added 13 commits November 27, 2023 20:41
…local machine or current user registry. need to figure out how to find other platforms through the registry then integrate into the main program
… Was unable to test it and code got a bit hadouken-y so will definitely need input from someone with Moonlight/Sunshine to test and with more experience coding to optimize/clean up a bit
…mplementation a bit easier, which also helped with the hadouken
…to a function but it's late and i'm going to bed
… launchers that have a .exe of the same name in the steamapps/common folder that just launches the launcher - now it should find the larger of the two .exes first (the actual game launcher)
removed testing grounds for registry search now that the functionality is implemented into the main program
Program.cs Outdated
@@ -174,23 +191,75 @@ void ScanFolder(string folder)
Console.WriteLine(""); //blank line to separate platforms
}

string MakePathGooder(string path)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename with a more descriptive function name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Program.cs Outdated
}
}
}
/*else if (path contains other installer keywords)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused comment blocks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Program.cs Outdated
{
if (library is not VProperty libProp)
var libraryFoldersPath = drive.Name + steamLibraryFolders;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments explaining how the Vdf stuff works?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments to code - not sure if you meant here or there.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move all the files back to where they were originally?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (i think)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to keep this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublishProfiles and .pubxml were in the .gitignore - added back

Program.cs Outdated
//@"*:\Program Files (x86)\Ubisoft\Ubisoft Game Launcher\games"
};

var registryDir = new List<string>()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these if they're not being used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used - need to be declared for ScanFolder method to work, as well as the adding addlDirectories on line 60

Program.cs Outdated
@@ -11,7 +12,20 @@
const string steamLibraryFolders = @"Program Files (x86)\Steam\steamapps\libraryfolders.vdf";

// default values
var gameDirs = new List<string>() { @"*:\Program Files (x86)\Steam\steamapps\common", @"*:\XboxGames", @"*:\Program Files\EA Games", @"*:\Program Files\Epic Games\", @"*:\Program Files (x86)\Ubisoft\Ubisoft Game Launcher\games" };
var gameDirs = new List<string>() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remov these if they're not being used

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used - need to be declared for RegistrySearch method to work

Program.cs Outdated
else
{
steamRegistry = Registry.CurrentUser.OpenSubKey(path);
if (steamRegistry != null && steamRegistry.GetValue("SteamPath") != null)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably dedupe these 2 conditional blocks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants