Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI tests (CRTM cmake errors) and remove dependency on w3nco #48

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 27, 2024

Description

  1. Use tag v3.1.0-skylabv7 for CRTM until problems with recently introduced plain cmake build are resolved
  2. Remove dependency on w3nco (replaced by w3emc); for more details see associated PR https://github.com/JCSDA-internal/fv3-jedi/pull/1127

Note. Once https://github.com/JCSDA-internal/fv3-jedi/pull/1127 is merged, need to revert the temporary branch name change for fv3-jedi

Issue(s) addressed

Resolves failing CI tests

This is a workaround for #49 (not a solution)

Dependencies

Impact

n/a

Checklist

@climbfuji climbfuji marked this pull request as ready for review January 27, 2024 03:23
@climbfuji climbfuji self-assigned this Jan 27, 2024
@climbfuji climbfuji added INFRA JEDI Infrastructure ALGO JEDI Algorithms CRTM CRTM labels Jan 27, 2024
@climbfuji
Copy link
Collaborator Author

@shlyaeva can you take a look at this PR when you have time, please?

@eap - FYI This PR was approved by Ben J beforehand, but the approval was dismissed when I pushed the latest commit.

@shlyaeva
Copy link
Collaborator

@climbfuji can you explain in a few words why this only affects ufs-bundle but not jedi-bundle? (or does it also affect jedi-bundle?)

@climbfuji
Copy link
Collaborator Author

@climbfuji can you explain in a few words why this only affects ufs-bundle but not jedi-bundle? (or does it also affect jedi-bundle?)

I can: I have no idea. But I assume it's because of the way we build the code - that whole mix and match of ecbuild packages for most packages, plain cmake for crtm, cmake external project for ufs-weather-model, is a fragile configuration. Going back to the release tag where crtm was an ecbuild package works. In jedi-bundle, we don't have all of that.

Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji sounds good to me, thank you!

@climbfuji climbfuji merged commit f19b55d into develop Jan 30, 2024
1 check passed
@climbfuji climbfuji deleted the feature/fix_ci_crtm_rel310 branch January 30, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO JEDI Algorithms CRTM CRTM INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants