Replace previous solution to suppress Intel's deprecation warnings with spack-blesssed version #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/intel_deprec_flags_new
6 tasks
climbfuji
requested review from
AlexanderRichert-NOAA,
srherbener and
RatkoVasic-NOAA
RatkoVasic-NOAA
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See JCSDA/spack-stack#1230 for what this PR does (all explained in detail). I cherry-picked all commits from spack#44588 to make sure that there are no merge conflicts down the road.
Acknowledging Peter Scheibel from the spack core team for suggesting the improved solution and adding the tests to my implementation.
Testing
See spack CI tests. See JCSDA/spack-stack#1238 for testing in spack-stack (manually and in CI).