Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subversion: pic variant & static openssl #337

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Subversion: pic variant & static openssl #337

merged 5 commits into from
Oct 4, 2023

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

Description

Somehow the pic variant and static openssl support for subversion got lost along the way. This PR restores them.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@AlexanderRichert-NOAA AlexanderRichert-NOAA changed the title Subversion pic Subversion: pic variant & static openssl Oct 3, 2023
@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as draft October 4, 2023 00:48
climbfuji
climbfuji approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost seems like life would be a easier with shared libraries.

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review October 4, 2023 20:33
@climbfuji climbfuji merged commit 5d802e7 into JCSDA:jcsda_emc_spack_stack Oct 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srherbener srherbener srherbener approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderRichert-NOAA @climbfuji @srherbener