-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of the removal of std::unary_function in C++17 #334
Add handling of the removal of std::unary_function in C++17 #334
Conversation
Also here it would be good to cherry-pick the updates for boost from spack develop and then applying the changes for all versions. |
8cc0267
to
68a6532
Compare
After fixing the syntax error, I re-tested on my Mac and boost built successfully. |
After fixing the coding style error, I re-tested on my Mac and boost built successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI tests passed for the associated spack-stack PR.
Description
The C++17 standard specifies that std::unary_function is to be removed. Boost has
#define
directives to handle this, but this requires defining the cxxflagBOOST_NO_CXX98_FUNCTION_BASE
on the build (b2) command line. This PR adds in a check for C++17 or newer and adds in the define mentioned above.This was discovered when trying to build on the Mac using the new [email protected] version. Apparently Apple did not remove std::unary_function until version 15.0.0 was released.
Issue(s) addressed
None
Dependencies
List the other PRs that this PR is dependent on:
None
Impact
Expected impact on downstream repositories:
None
Checklist