Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of the removal of std::unary_function in C++17 #334

Merged

Conversation

srherbener
Copy link
Collaborator

Description

The C++17 standard specifies that std::unary_function is to be removed. Boost has #define directives to handle this, but this requires defining the cxxflag BOOST_NO_CXX98_FUNCTION_BASE on the build (b2) command line. This PR adds in a check for C++17 or newer and adds in the define mentioned above.

This was discovered when trying to build on the Mac using the new [email protected] version. Apparently Apple did not remove std::unary_function until version 15.0.0 was released.

Issue(s) addressed

None

Dependencies

List the other PRs that this PR is dependent on:
None

Impact

Expected impact on downstream repositories:
None

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (N/A)
  • I have run the unit tests before creating the PR (tested manually on my Mac)

@srherbener srherbener added the INFRA JEDI Infrastructure label Oct 3, 2023
@climbfuji
Copy link
Collaborator

Also here it would be good to cherry-pick the updates for boost from spack develop and then applying the changes for all versions.

@srherbener srherbener force-pushed the feature/boost-c++17 branch from 8cc0267 to 68a6532 Compare October 3, 2023 20:19
@srherbener
Copy link
Collaborator Author

After fixing the syntax error, I re-tested on my Mac and boost built successfully.

@srherbener
Copy link
Collaborator Author

After fixing the coding style error, I re-tested on my Mac and boost built successfully.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests passed for the associated spack-stack PR.

@climbfuji climbfuji merged commit 0148496 into JCSDA:jcsda_emc_spack_stack Oct 5, 2023
2 checks passed
@srherbener srherbener deleted the feature/boost-c++17 branch October 5, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants