Bug fixes for libjpeg-turbo, hdf (hdf4), and hdf-eos2 to enable graphics variants in MET #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
feature/met_graphics
branch
from
278630d to
1faf44f
Compare
…s/hdf-eos2/package.py, fix dependencies to match what hdf provides
…ckages/hdf/package.py
…eg-turbo/package.py
climbfuji
force-pushed
the
feature/met_graphics
branch
from
1faf44f to
ed76b50
Compare
…into feature/met_graphics
climbfuji
changed the title
Co-authored-by: Tamara Dahlgren <[email protected]>
climbfuji
requested review from
mathomp4,
ulmononian,
natalie-perlin and
AlexanderRichert-NOAA
climbfuji
changed the title
ulmononian
approved these changes
Sep 6, 2023
…into feature/met_graphics
…into feature/met_graphics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three small bug fixes that I will cherry-pick and send to spack upstream separately:
libjpeg-turboas we've done multiple times for other packages.h4ccwrapper inhdf(solution stolen from another package). Turns out this opens a can of worms for poorly configured packages usingh4cc, see next item.configureinhdf-eos2so thatfilter_filecan operate on the file (solution stolen from another package), and make the dependencies match those hard-coded inhdf(necessary, because of the wayhdf-eos2is built using theh4cccompiler wrapper).spack PRs:
Testing
Tested as part of JCSDA/spack-stack#760
Issues
See JCSDA/spack-stack#760