Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scotch #260

Merged
merged 5 commits into from
May 19, 2023
Merged

Add scotch #260

merged 5 commits into from
May 19, 2023

Conversation

ulmononian
Copy link
Collaborator

@ulmononian ulmononian commented Apr 20, 2023

WW3 requires the scotch package for mesh/graph partitioning (see spack-stack #465, #336).

This adds a checksum for scotch/7.0.3 as well as two new variants (to turn off threading) to the scotch package.py. It also adds scotch to the ufs-weather-model-env package.py.

Installs successfully as standalone package and as a part of ufs-weather-model-env (intel & gcc) on Orion and Hera.

WW3 runs successfully with new variants on Hera.

main spack PR: spack#37054
spack-stack PR: JCSDA/spack-stack#550

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, but we need to get the CI tests up and running again in your companion spack-stack PR. I'll work on that today/tomorrow.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark this as "Request changes" because I am aware of segfaults on Hera that need to be figured out first. Otherwise, the PR looks good, installs cleanly in CI (macOS, Ubuntu), see https://github.com/NOAA-EMC/spack-stack/pull/550/files

@ulmononian
Copy link
Collaborator Author

ulmononian commented Apr 21, 2023

I'll mark this as "Request changes" because I am aware of segfaults on Hera that need to be figured out first. Otherwise, the PR looks good, installs cleanly in CI (macOS, Ubuntu), see https://github.com/NOAA-EMC/spack-stack/pull/550/files

i believe the reported segfaults were using the hpc-stack version, so i need to try to build that slightly differently. i don't think anyone tested the spack-stack version of 7.0.3 within the context of ww3 yet, but hoping that goes more smoothly. will report back.

@climbfuji
Copy link
Collaborator

I'll mark this as "Request changes" because I am aware of segfaults on Hera that need to be figured out first. Otherwise, the PR looks good, installs cleanly in CI (macOS, Ubuntu), see https://github.com/NOAA-EMC/spack-stack/pull/550/files

i believe the reported segfaults were using the hpc-stack version, so i need to try to build that slightly differently. i don't think anyone tested the spack-stack version of 7.0.3 within the context of ww3 yet, but hoping that goes more smoothly. will report back.

Ok, please let me know when you had a chance to test it and I can approve/merge. Thanks!

@ulmononian
Copy link
Collaborator Author

I'll mark this as "Request changes" because I am aware of segfaults on Hera that need to be figured out first. Otherwise, the PR looks good, installs cleanly in CI (macOS, Ubuntu), see https://github.com/NOAA-EMC/spack-stack/pull/550/files

@climbfuji i just merged develop into this. now it is just the scotch updates for spack that need to precede JCSDA/spack-stack#550.

@climbfuji climbfuji merged commit 792bf0d into JCSDA:jcsda_emc_spack_stack May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants