-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scotch #260
Add scotch #260
Conversation
…o ufs-weather-model-env in jcsdca-emc-bundles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, but we need to get the CI tests up and running again in your companion spack-stack PR. I'll work on that today/tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll mark this as "Request changes" because I am aware of segfaults on Hera that need to be figured out first. Otherwise, the PR looks good, installs cleanly in CI (macOS, Ubuntu), see https://github.com/NOAA-EMC/spack-stack/pull/550/files
i believe the reported segfaults were using the hpc-stack version, so i need to try to build that slightly differently. i don't think anyone tested the spack-stack version of 7.0.3 within the context of ww3 yet, but hoping that goes more smoothly. will report back. |
Ok, please let me know when you had a chance to test it and I can approve/merge. Thanks! |
…into feature/add_scotch
…into feature/add_scotch
@climbfuji i just merged develop into this. now it is just the scotch updates for spack that need to precede JCSDA/spack-stack#550. |
WW3 requires the
scotch
package for mesh/graph partitioning (see spack-stack #465, #336).This adds a checksum for
scotch/7.0.3
as well as two new variants (to turn off threading) to the scotch package.py. It also addsscotch
to the ufs-weather-model-env package.py.Installs successfully as standalone package and as a part of ufs-weather-model-env (intel & gcc) on Orion and Hera.
WW3 runs successfully with new variants on Hera.
main spack PR: spack#37054
spack-stack PR: JCSDA/spack-stack#550