✅ #133 add unit test for preference entries loader

src/jagfx/core/configuration/preference-entry/filter.spec.js

@@ -1,7 +1,28 @@
-import { existingConfiguration } from "./preference-entry.mock.js";
 import { PreferenceEntry } from "@/jagfx/core/configuration/preference-entry/PreferenceEntry";
 import { applyFiltersToPreferenceEntriesList } from "@/jagfx/core/configuration/preference-entry/filter";
 
+const existingConfiguration = [
+  {
+    id: "an_existing_configuration_id",
+    target: "application",
+    label: "Configuration 1",
+    description: "Description 1",
+    values: [
+      {
+        label: "Value 1",
+        value: "value1",
+      },
+    ],
+  },
+  {
+    id: "another_existing_configuration_id",
+    target: "application",
+    label: "Unicorn label 2",
+    description: "Description 2",
+    values: null,
+  },
+];
+
 describe("Preference entry filter", () => {
   const unknownFilters = [
     [],

src/jagfx/core/configuration/preference-entry/finder.spec.js

@@ -1,15 +1,31 @@
-import PreferenceEntryMock from "./preference-entry.mock.js";
 import { PreferenceEntry } from "@/jagfx/core/configuration/preference-entry/PreferenceEntry";
 import {
   convertJsonObjectToPreferenceEntry,
   findPreferenceEntryById,
 } from "@/jagfx/core/configuration/preference-entry/finder";
-import {
-  existingConfiguration,
-  existingConfigurationId,
-} from "@/jagfx/core/configuration/preference-entry/preference-entry.mock";
 
-// TODO Find a way to use an external mock file
+const existingConfigurationId = "an_existing_configuration_id";
+const existingConfiguration = [
+  {
+    id: "an_existing_configuration_id",
+    target: "application",
+    label: "Configuration 1",
+    description: "Description 1",
+    values: [
+      {
+        label: "Value 1",
+        value: "value1",
+      },
+    ],
+  },
+  {
+    id: "another_existing_configuration_id",
+    target: "application",
+    label: "Unicorn label 2",
+    description: "Description 2",
+    values: null,
+  },
+];
 
 jest.mock(
   "@/jagfx/core/configuration/preference-entry/map.json",

src/jagfx/core/configuration/preference-entry/loader.js

@@ -1,4 +1,15 @@
 export const loadPreferenceEntryValues = (preferenceEntry) => {
+  if (
+    Array.isArray(preferenceEntry) ||
+    preferenceEntry === null ||
+    typeof preferenceEntry !== "object" ||
+    !Array.isArray(preferenceEntry.values) ||
+    !Object.hasOwnProperty.call(preferenceEntry, "values") ||
+    preferenceEntry.values === null
+  ) {
+    return null;
+  }
+
   if (
     Array.isArray(preferenceEntry.values) &&
     preferenceEntry.values.length > 0
@@ -17,4 +28,4 @@ export const loadPreferenceEntryValues = (preferenceEntry) => {
   return null;
 };
 
-// TODO Add test for it + tast to check all entry on map.json file
+// TODO Add test for it + tast to check all entry on map.json file

src/jagfx/core/configuration/preference-entry/loader.spec.js

@@ -0,0 +1,36 @@
+import { loadPreferenceEntryValues } from "@/jagfx/core/configuration/preference-entry/loader";
+
+const mockPreferenceEntry = (values) => ({
+  values,
+});
+
+describe("Preference entries finder", () => {
+  // Array not empty > Return this array
+  // Array empty  > Perform external request
+  // Null         > No value, return null
+  it("Should return the same array if preference entry value is an array not empty", () => {
+    const preferenceEntry = mockPreferenceEntry(["some", "stuff"]);
+
+    expect(loadPreferenceEntryValues(preferenceEntry)).toBe(
+      preferenceEntry.values
+    );
+  });
+
+  const invalidPreferenceEntries = [
+    {},
+    "",
+    "string",
+    123,
+    undefined,
+    null,
+    new Event(""),
+    { label: "" },
+    mockPreferenceEntry(null),
+  ];
+  it.each(invalidPreferenceEntries)(
+    "Should return null with invalid preferenceEntry",
+    (invalidPreferenceEntry) => {
+      expect(loadPreferenceEntryValues(invalidPreferenceEntry)).toBeNull();
+    }
+  );
+});