Merge pull request stringer-rss#237 from jmazzi/feature/export_to_file

Make export feeds serve a file
J0HAN85 · Jul 18, 2013 · 70c4036 · 70c4036
2 parents b39243e + f9fe38f
commit 70c4036
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/controllers/feeds_controller.rb b/app/controllers/feeds_controller.rb
@@ -48,7 +48,8 @@ class Stringer < Sinatra::Base
   end
 
   get "/feeds/export" do
-    content_type :xml
+    content_type 'application/octet-stream'
+    attachment 'stringer.xml'
 
     ExportToOpml.new(Feed.all).to_xml
   end

diff --git a/spec/controllers/feeds_controller_spec.rb b/spec/controllers/feeds_controller_spec.rb
@@ -117,11 +117,12 @@
 
     it "returns an OPML file" do
       ExportToOpml.any_instance.should_receive(:to_xml).and_return(some_xml)
-    
+
       get "/feeds/export"
 
       last_response.body.should eq some_xml
-      last_response.header["Content-Type"].should include 'xml'
+      last_response.header["Content-Type"].should include 'application/octet-stream'
+      last_response.header["Content-Disposition"].should == "attachment; filename=\"stringer.xml\""
     end
   end
 end