Inline images #356
Merged
Inline images #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request lays the groundwork to properly support inline images.
What makes inline images hard to support, is that they include a data stream of arbitrary bytes and unknown length. If the (final) filter on the stream has an EOD marker, finding the end isn't that hard (although it isn't hard, this PR doesn't implement it).
If the (final) filter doesn't have an EOD marker, it's much harder to find the end, as it effectively forces the us to decompress the stream.
This PR addresses #78 and #221, but I wouldn't say that the issue is resolved. In practice, the images are compressed in some way, and this PR doesn't implement that.