Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Outcome result data #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hug963
Copy link

@hug963 hug963 commented Aug 16, 2018

There is currently no way to attach a result data to an outcome.
This adds that feature. :)

@dac514
Copy link
Collaborator

dac514 commented Feb 13, 2019

Late to the party here but I am looking at this code today.

  • Name: ext_outcome_data_values_accepted
  • Required: Yes
  • Description: Presence of this key indicates that the consumer is capable of using the resultData extension. The value should be a comma separated list of: url, text, or values agreed upon between consumer and provider.

Source: https://www.edu-apps.org/extensions/result_data.html

It feels to me there's some code missing?

If you look at the top of \IMSGlobal\LTI\ToolProvider\ResourceLink::doOutcomesService you'll see code like:

$urlLTI11 = $sourceResourceLink->getSetting('lis_outcome_service_url');
$urlExt = $sourceResourceLink->getSetting('ext_ims_lis_basic_outcome_url');

Which is used as a condition to check if <resultRecord> should be printed.

IMHO, you should add ext_outcome_data_values_accepted to \IMSGlobal\LTI\ToolProvider\ToolProvider::$LTI_RESOURCE_LINK_SETTING_NAMES

And check <resultData> against it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants