modify regex so it ensures start of string when validating vat number…

…s. see #2
Ixolit · Nov 2, 2016 · e86dfa1 · e86dfa1
1 parent c5de749
commit e86dfa1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/Validator.php b/src/Validator.php
@@ -74,7 +74,8 @@ public function validateFormat( $vatNumber ) {
             return false;
         }
 
-        return preg_match( '/' . self::$patterns[$country] . '$/', $number ) > 0;
+        $matches = preg_match( '/^' . self::$patterns[$country] . '$/', $number ) > 0;
+        return $matches;
     }
 
     /**

diff --git a/tests/ValidatorTest.php b/tests/ValidatorTest.php
@@ -89,10 +89,12 @@ public function test_validateFormat() {
             'SE12345678901',
             'SI1234567',
             'SK123456789',
+            'fooGB999999973', // valid VAT number but with string prefix
         ];
 
         foreach( $invalid as $format ) {
-            self::assertFalse( $validator->validateFormat( $format ), "{$format} passed validation, but shouldn't." );
+            $isValid = $validator->validateFormat( $format );
+            self::assertFalse( $isValid, "{$format} passed validation, but shouldn't." );
         }
     }