Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch Client Update -> 1.5.7, along with various bug fixes #280

Open
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

hickorysb
Copy link

Adds support for the dispatch client (currently private finishing configuration settings): TokoVoip Dispatch Client by HickorySB

@hickorysb
Copy link
Author

The client source has been made public now with a temporary command-line client while the graphical client is finished.

@hickorysb
Copy link
Author

hickorysb commented Apr 24, 2021

Commit 65d697f addresses OneSync Infinity issue
Commit f399ccb addresses a mouth animation issue (didn't help, trying again)

@hickorysb hickorysb changed the title Dispatch Client Update -> 1.5.7 Dispatch Client Update -> 1.5.7, along with various bug fixes Apr 24, 2021
@Itokoyamato
Copy link
Owner

@hickorysb Mind giving more details about what the onesync infinity issue was ?

@hickorysb
Copy link
Author

@Itokoyamato retrieve the player list server side and send it client side. Due to player culling.

@Itokoyamato
Copy link
Owner

Does the player culling cause an issue for proximity chat ? My understanding of it was that it retrieves players close enough (which was enough for proximity chat), and then we apply radio channels players from the channels themselves. Are we actually missing certains players in proximity due to culling ? Cause retrieving the entire player list is a lot of data, and the culling seemed to work in favor of saving data to send to TS3

@hickorysb
Copy link
Author

Several players report that with player culling players who are far apart when they first join will often be able to hear each other. I know there was a feature implemented into the plugin to handle that, but apparently it isn't working. might not be an issue and might be use error. I can revert the change in a bit.

@Itokoyamato
Copy link
Owner

Yeah we might've to investigate this issue a bit more if it's possible to fix another way.

Considering the latency between the fivem client and the ts3 server due to the proxying through ws-server, the lower the data payload, the better.
And player culling was working in this favour, as well as client performance to loop through dozens of players instead of hundreds on the process loop

@hickorysb
Copy link
Author

It appears that the original fix in the plugin is working. The players reporting the bug were using previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants