Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokovoip.cpp #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update tokovoip.cpp #198

wants to merge 1 commit into from

Conversation

fk-1997
Copy link

@fk-1997 fk-1997 commented Sep 8, 2020

deactivated client mute to fix problems with voice activation

deactivated client mute to fix problems with voice activation
@Itokoyamato
Copy link
Owner

Thanks for the contribution, and sorry for the delay.
While this surely fixes the issue for voice activation, won't this change leave those with push to talk with their input always open ?

@pietrodicaprio
Copy link

I'm not 100% of what I wrote since, unfortunately, I don't know C++.
My proposal is to check if the user's is still talking before force-muting his input if not talking in radio anymore:

// Activate input if talking on radio
	if (radioTalking)
	{
		setClientTalking(true);
		if (!isTalking && radioClicks == true && local_click_on == true)
			playWavFile("mic_click_on");
		isTalking = true;
	}
	else
	{
		if (isTalking)
		{
			if (radioClicks == true && local_click_off == true)
			{
				playWavFile("mic_click_off");
			}
			isTalking = false;
			
			uint64 serverId = ts3Functions.getCurrentServerConnectionHandlerID();
			int talkStatus = 1;
			int isWhispering = 0;
			
			if(TSHelpers.GetTalkStatus(serverId, getMyId(serverId), &talkStatus, &isWhispering) != 1)
			{
				setClientTalking(false);
			}
		}
	}

does it make sense?

@JaroSound
Copy link

Why not use the old system? When someone is close he is not muted. This was working perfectly fine... Now its laggy and buggy.

@Lickers
Copy link

Lickers commented Dec 16, 2020

Hi! After change the code in cpp, how to repack the master file in a ts3 plugin for test? thanks

@Poggicek
Copy link
Contributor

How about adding delay for the setClientTalking instead of just removing it? That should fix voice cut problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants