fix(ws-server): delete handshake on clientIP update

Itokoyamato · Mar 10, 2021 · efbb4c5 · efbb4c5 · Nizzy-crrp · Mar 10, 2021
1 parent e4bcce7
commit efbb4c5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/ws_server/index.js b/ws_server/index.js
@@ -154,7 +154,10 @@ io.on('connection', async socket => {
     socketHeartbeat(socket);
     socket.on('updateClientIP', data => {
       if (!data || !data.ip || !IPv4Regex.test(data.ip) || !clients[socket.uuid]) return;
-      if (lodash.get(clients, `[${socket.uuid}].fivem.socket`)) clients[socket.uuid].fivem.socket.clientIp = data.ip;
+      if (lodash.get(clients, `[${socket.uuid}].fivem.socket`)) {
+        delete handshakes[clients[socket.uuid].fivem.socket.clientIp];
+        clients[socket.uuid].fivem.socket.clientIp = data.ip;
+      }
       if (lodash.get(clients, `[${socket.uuid}].ts3.socket`)) clients[socket.uuid].ts3.socket.clientIp = data.ip;
     });
     await registerHandshake(socket);