-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-9995] reorganize source code #599
Merged
lposen
merged 29 commits into
2.0.0-alpha/master
from
2.0.0-alpha/MOB-9995-reorganize-source-code
Dec 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
33dcd4b
Refactor file structure: move `IterableInbox` to `inbox` directory an…
lposen a1d215f
Update imports for IterableInboxCustomizations to reflect new file st…
lposen e5ff188
Refactor file structure: move inbox-related components to `inbox` dir…
lposen 827462a
Refactor imports: consolidate IterableInApp classes into a single inA…
lposen 27f1bf0
Refactor in-app structure: separate classes into individual files, in…
lposen 507902a
Refactor inbox structure: move components to a new `components` direc…
lposen fd2ea12
Refactor Iterable module: rename AuthResponseCallback to IterableAuth…
lposen 5af5f45
Refactor event names: rename EventName to IterableEventName in Iterab…
lposen 7cf303c
Refactor enums: move IterableAuthResponseResult, IterableEventName, a…
lposen 95c4988
Refactor Iterable module: move IterableActionContext to a new file, u…
lposen 3a52215
Refactor Iterable module: update imports for IterableAuthResponse and…
lposen 9ac9906
Refactor Iterable module: update imports for IterableActionContext, I…
lposen 20b10a3
Refactor Iterable module: move IterablePushPlatform enum to a separat…
lposen f7066e7
Refactor imports in IterableLogger, IterableUtil, and IterableInAppMe…
lposen 5a1eea0
Refactor Iterable module: update imports for consistency and rename t…
lposen 1db7ca4
Refactor imports in Iterable module: update paths to use absolute imp…
lposen 04dc426
Refactor imports and restructure files in Iterable module: consolidat…
lposen 1393e4b
Undid local path changes as they do not work with the build
lposen 6cfa8a2
Fix import path for package.json in Iterable class to ensure correct …
lposen 4688446
Refactor types in inbox module: change type aliases to interfaces for…
lposen f96f5c9
Merge branch '2.0.0-alpha/MOB-10131-remove-duplicate-code' into 2.0.0…
lposen 3d92e26
Changed file order as it was messing with mocks
lposen e6d729f
Merge branch '2.0.0-alpha/MOB-9995-reorganize-source-code' of github.…
lposen 65aa68c
Merge branch '2.0.0-alpha/MOB-10131-remove-duplicate-code' into 2.0.0…
lposen 4216fa7
Remove default exports from Iterable classes and enums
lposen 8ea2a20
Merge branch '2.0.0-alpha/MOB-10131-remove-duplicate-code' into 2.0.0…
lposen a20baec
Merge branch '2.0.0-alpha/MOB-10131-remove-duplicate-code' into 2.0.0…
lposen c8ece69
Merge branch '2.0.0-alpha/MOB-10131-remove-duplicate-code' into 2.0.0…
lposen a7dccb5
Merge branch '2.0.0-alpha/master' into 2.0.0-alpha/MOB-9995-reorganiz…
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
src/IterableInAppManager.ts → src/inApp/IterableInAppManager.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/IterableInAppMessage.ts → src/inApp/IterableInAppMessage.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export * from './IterableInAppClasses'; | ||
export * from './IterableInAppManager'; | ||
export * from './IterableInAppMessage'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,10 +14,7 @@ import { SafeAreaView } from 'react-native-safe-area-context'; | |
import type { InboxImpressionRowInfo } from '../InboxImpressionRowInfo'; | ||
import type { InboxRowViewModel } from '../InboxRowViewModel'; | ||
import { Iterable } from '../Iterable'; | ||
import { | ||
IterableInAppDeleteSource, | ||
IterableInAppLocation, | ||
} from '../IterableInAppClasses'; | ||
import { IterableInAppDeleteSource, IterableInAppLocation } from '../inApp'; | ||
import { useAppStateListener, useDeviceOrientation } from '../hooks'; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of the index file. The imports are very organized. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! |
||
import type { IterableInboxCustomizations } from './IterableInboxCustomizations'; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice I like the reorganization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'm glad