Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-10131] remove duplicate code #598

Merged

Conversation

lposen
Copy link
Contributor

@lposen lposen commented Nov 7, 2024

🔹 JIRA Ticket(s) if any

✏️ Description

Removes duplicate code from repository

Copy link

github-actions bot commented Nov 7, 2024

Lines Statements Branches Functions
Coverage: 36%
36.63% (174/475) 11.56% (20/173) 31.84% (50/157)

@lposen lposen changed the title [MOB-10131] remove-duplicate-code [MOB-10131] remove duplicate code Nov 14, 2024
Base automatically changed from 2.0.0-alpha/MOB-9673-new-unit-tests to 2.0.0-alpha/master November 27, 2024 23:51
An error occurred while trying to automatically change base from 2.0.0-alpha/MOB-9673-new-unit-tests to 2.0.0-alpha/master November 27, 2024 23:51
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nit picks.


/**
* IterableAction represents an action defined as a response to user events.
* It is currently used in push notification actions (open push & action buttons).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also used for action buttons for in-app and embedded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a description for IterableActionContext

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done in a future PR

@lposen lposen merged commit 7cae386 into 2.0.0-alpha/master Dec 3, 2024
3 of 4 checks passed
@lposen lposen deleted the 2.0.0-alpha/MOB-10131-remove-duplicate-code branch December 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants