Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for userId in sample app #527

Merged
merged 4 commits into from
Apr 13, 2024
Merged

add support for userId in sample app #527

merged 4 commits into from
Apr 13, 2024

Conversation

hani-iterable
Copy link

Description

  • Release Notes

We have successfully implemented support for the userId in Sample App for both JavaScript and TypeScript Apps.

  • Test Steps
  1. Run the Sample App.
  2. Navigate to the Settings tab.
  3. Locate the field for entering email/userId.
  4. Enter the appropriate value and press the login button.
  5. Verify that the email/userId is displayed as the user.
  6. Click the Logout button.
  7. Confirm that the field for entering email/userId is visible again.

evantk91
evantk91 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added missing regex.

@evantk91 evantk91 merged commit 4bdaf22 into master Apr 13, 2024
1 of 2 checks passed
@evantk91 evantk91 deleted the support_user_id branch April 13, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantk91 evantk91 evantk91 approved these changes

Assignees

@evantk91 evantk91

Labels
omni-cg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hani-iterable @evantk91 @hani329