Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-7252] sets up click handling for external/deep linking #687

Merged
merged 10 commits into from
Nov 13, 2023

Conversation

evantk91
Copy link
Collaborator

@evantk91 evantk91 commented Nov 7, 2023

🔹 Jira Ticket(s)

✏️ Description

  • sets up the handleEmbeddedClick function which can be called app side where a click is handled
  • sets up functionality for validating the URL and calling the urlHandler set up on the app side in the urlDelegate in the config
  • Adds embedded manager reset and associated unit tests

Copy link
Contributor

@bradumbaugh bradumbaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evantk91 Hey Evan, not sure I'm the right person to approve this PR, but left a couple of comments.

Three questions, too:

1 - Where would the client programmer call the method to track a click event? Nevermind, was thinking about this wrong.

2 - After a click, how would the client programmer know to update the UI that displayed the message? Nevermind, was thinking about this wrong.

@evantk91 evantk91 changed the title [MOB-7252] sets up click handling [MOB-7252] sets up click handling for external/deep linking Nov 9, 2023
@vbabenkoru
Copy link
Contributor

Could you add some unit tests for this?

@evantk91
Copy link
Collaborator Author

Could you add some unit tests for this?

I will add as a fast follow on a separate PR since we are targeting testing by next wednesday.

@evantk91
Copy link
Collaborator Author

Could you add some unit tests for this?

I will add as a fast follow on a separate PR since we are targeting testing by next wednesday.

This functionality is actually covered by ActionRunnerTests.swift. The added functionality for embedded just processes the click information and passes it to the same action runner that in-app messages use.

@evantk91 evantk91 merged commit 3e10675 into embedded-messaging Nov 13, 2023
2 checks passed
@evantk91 evantk91 deleted the evan/MOB-7252-sets-up-click-handling branch November 13, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants