[MOB - 6865] - Keychain null crash fix #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handles condition where IterableKeychain creation returns null to Iterable API. SDK will continue to process without crashing. There will be no email fetched from sharedPreferences in this rare case. No email will be persisted and the app will have to setEmail/setUserId on every app session for it to have email in memory than having it persisted for consequent app sessions - Fixed indentation on IterableKeychain file. Using cmd+l on Android Studio - Added method description in IterableConfig class so developers have more context on what `setEncryptionEnforced` means - getKeychain is now annotated @nullable for future kotlin migration purpose
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Ayyanchira
commented
Sep 21, 2023
Comment on lines
120
to
125
| editor.remove(IterableConstants.SHARED_PREFS_USERID_KEY) | ||
| IterableLogger.v(TAG, | ||
| IterableLogger.v( | ||
| TAG, | ||
| "UPDATED: migrated userId from SharedPreferences to IterableKeychain" | ||
| ) | ||
| } else if (sharedPrefsUserId != null) { |
Ayyanchira
commented
Sep 21, 2023
1. Checking for Throwable which will collect both Exception and Error if at all Security library is crashing with a Error and not exception. 2. Updating the dependency to use latest alpha version. Alpha version 5 also seems to fix race condition during creation process. Reference - https://developer.android.com/jetpack/androidx/releases/security#1.1.0-alpha05 3. Added some warning logs if this situation arrives so developers can take some action if it occurs during debugging
Catching Error along with Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
Handles condition where IterableKeychain creation returns null to Iterable API. SDK will continue to process without crashing.
There will be no email fetched from sharedPreferences in this rare case. No email will be persisted and the app will have to setEmail/setUserId on every app session for it to have email in memory than having it persisted for consequent app sessions
Fixed indentation on IterableKeychain file. Using cmd+l on Android Studio
Added method description in IterableConfig class so developers have more context on what
setEncryptionEnforcedmeansgetKeychain is now annotated @nullable for future kotlin migration purpose
Fixes - #616
Fixes - #631