Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Angular code by removing decorators #2035

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Oct 6, 2024

@Input => input
@Output => output
@Viewchild => viewChild
@ViewChildren => viewChildren
Move inject code from constructor to inject method.
Fix relevant tests and code.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (80033ab) to head (b6b1b94).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   91.33%   91.33%   -0.01%     
==========================================
  Files          93       93              
  Lines        8106     8103       -3     
  Branches      985      985              
==========================================
- Hits         7404     7401       -3     
  Misses        477      477              
  Partials      225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM changed the title Move to use inject instead of constructor inject Modernize Angular code by removing decorators Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants