Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1906 no fits rdf mapping #55

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Resolves Islandora/documentation#1906

What does this Pull Request do?

Adds an RDF mapping for FITS and configures the appropriate context to make indexing happen

How should this be tested?

  • Go to a FITS media in your Islandora instance and check out its JSONLD. It should be pretty empty.
  • Apply this PR and re-import the feature (or you could be surgical and just add the configs in this PR to your site using Drupal's config sync tools if you've customized your config significantly)
  • Clear your cache
  • Now go check out the JSONLD for a FITS file and it should be full of useful information
  • BONUS POINTS: Check out the RDF in Fedora and confirm it's also full of useful information

Interested parties

@Islandora/8-x-committers

@rosiel rosiel changed the base branch from 8.x-1.x to 2.x October 5, 2021 21:29
@seth-shaw-unlv
Copy link
Contributor

seth-shaw-unlv commented Oct 6, 2021

The build failed because the RDF mappings presume we have the FITS Media type included in islandora_defaults, except they don't exist unless you have included the roblib/islandora_fits module. We either need to

  • add roblib/islandora_fits to the composer.json and the islandora_defaults.info.yml OR
  • move the RDF config to roblib/islandora_fits and use their install hook to add fites_technical_metadata to the context.context.all_media config.

@ruebot
Copy link
Member

ruebot commented Nov 17, 2021

Tested in our setup, and looks good. Thanks @dannylamb!

Screenshot from 2021-11-17 14-41-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FITS Media Type doesn't have an RDF Mapping
3 participants