Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use the new custom modal builder #2053

Merged

Conversation

candela97
Copy link
Collaborator

@candela97 candela97 commented Sep 16, 2024

.

@tfedor
Copy link
Member

tfedor commented Sep 16, 2024

Width of the form like this won't work. Width must be defined when the modal is created, otherwise the modal won't be centered.

@candela97
Copy link
Collaborator Author

candela97 commented Sep 16, 2024

It looks just the same to me before and after this pr 🤔

I think the resize event handles this.

@tfedor
Copy link
Member

tfedor commented Sep 16, 2024

Looks like you're right, but it's weird because I remember it didn't work when I was implementing it - that's why I added that to the div directly. Not quite sure what's different now.

@tfedor tfedor merged commit c979f9b into IsThereAnyDeal:develop Nov 19, 2024
3 of 6 checks passed
@candela97 candela97 deleted the refactor-apply-custommodal-builder branch November 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants