Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCustomTags: rework and svelte-fy #2032

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

candela97
Copy link
Collaborator

  1. Custom tags were stored by guide id in local storage, which were easily lost, so we now fetch and parse the guide page (when editing own guides) to get enabled tags, and only store recently enabled tags in local storage for use when creating new guides.
  2. Custom tags depended on the feature that enables multi-selected languages (otherwise the tag inputs won't get checked correctly), and only worked because the feature array happened to be in the right order. This moves that feature into custom tags since it doesn't really make sense without it (extra language tags will be lost when you edit the guide after saving).

TODO Remove old local storage key.

@candela97 candela97 force-pushed the refactor-customtags branch from 960c67d to cc3fa45 Compare August 29, 2024 21:27
@tfedor
Copy link
Member

tfedor commented Sep 15, 2024

You use new LocalStorage key, but I don't see a migration from the old one to new one. Am I just missing it?

@tfedor tfedor merged commit 2bc900c into IsThereAnyDeal:develop Sep 15, 2024
@candela97 candela97 deleted the refactor-customtags branch September 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants