fixes LUNA-212 Failing to save should have an error toast!!!!

Ironclad · Mar 24, 2024 · 2137b3f · 2137b3f
1 parent bf768f4
commit 2137b3f
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 30 deletions.
diff --git a/packages/app/src/hooks/useSaveProject.ts b/packages/app/src/hooks/useSaveProject.ts
@@ -30,18 +30,23 @@ export function useSaveProject() {
       saving = toast.info('Saving project');
     }, 500);
 
-    await ioProvider.saveProjectDataNoPrompt(newProject, { testSuites }, loadedProject.path);
+    try {
+      await ioProvider.saveProjectDataNoPrompt(newProject, { testSuites }, loadedProject.path);
 
-    if (saving != null) {
-      toast.dismiss(saving);
-    }
-    clearTimeout(savingTimeout);
+      if (saving != null) {
+        toast.dismiss(saving);
+      }
+      clearTimeout(savingTimeout);
 
-    toast.success('Project saved');
-    setLoadedProject({
-      loaded: true,
-      path: loadedProject.path,
-    });
+      toast.success('Project saved');
+      setLoadedProject({
+        loaded: true,
+        path: loadedProject.path,
+      });
+    } catch (cause) {
+      clearTimeout(savingTimeout);
+      toast.error('Failed to save project');
+    }
   }
 
   async function saveProjectAs() {
@@ -57,26 +62,31 @@ export function useSaveProject() {
       saving = toast.info('Saving project');
     }, 500);
 
-    const filePath = await ioProvider.saveProjectData(newProject, { testSuites });
+    try {
+      const filePath = await ioProvider.saveProjectData(newProject, { testSuites });
 
-    if (saving != null) {
-      toast.dismiss(saving);
-    }
-    clearTimeout(savingTimeout);
+      if (saving != null) {
+        toast.dismiss(saving);
+      }
+      clearTimeout(savingTimeout);
 
-    if (filePath) {
-      toast.success('Project saved');
-      setLoadedProject({
-        loaded: true,
-        path: filePath,
-      });
-      setOpenedProjects((projects) => ({
-        ...projects,
-        [project.metadata.id]: {
-          project,
-          fsPath: filePath,
-        },
-      }));
+      if (filePath) {
+        toast.success('Project saved');
+        setLoadedProject({
+          loaded: true,
+          path: filePath,
+        });
+        setOpenedProjects((projects) => ({
+          ...projects,
+          [project.metadata.id]: {
+            project,
+            fsPath: filePath,
+          },
+        }));
+      }
+    } catch (cause) {
+      clearTimeout(savingTimeout);
+      toast.error('Failed to save project');
     }
   }
 

diff --git a/packages/core/src/utils/serialization/serialization_v4.ts b/packages/core/src/utils/serialization/serialization_v4.ts
@@ -94,9 +94,12 @@ export function graphV4Deserializer(data: unknown): NodeGraph {
 
 export function projectV4Serializer(project: Project, attachedData?: AttachedData): unknown {
   const filteredProject = {
-    ...project
+    ...project,
+    metadata: {
+      ...project.metadata,
+      path: undefined,
+    }
   }
-  delete filteredProject.metadata.path;
 
   // Make sure all data is ordered deterministically first
   const stabilized = JSON.parse(stableStringify(toSerializedProject(filteredProject, attachedData)));