Improve typing

Iron-Stag-Games · Nov 22, 2023 · af61010 · af61010
1 parent 1b0bdd5
commit af61010
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/Pronghorn/New.lua b/Pronghorn/New.lua
@@ -45,8 +45,8 @@ local QUEUED_EVENT_QUEUE_SIZE = 256
 --- @error Parent parameter used more than once -- Incorrect usage.
 --- @error Name parameter used more than once -- Incorrect usage.
 --- @error Properties parameter used more than once -- Incorrect usage.
-function New.Instance(className: string, ...: any?): any
-	local parent: Instance?, name: string?, properties: {[string]: any, Children: {Instance}?}?
+function New.Instance(className: string, ...: (Instance | string | {[string]: any, Children: {Instance}?, Attributes: {[string]: any}?, Tags: {string}?})?): any
+	local parent: Instance?, name: string?, properties: {[string]: any, Children: {Instance}?, Attributes: {[string]: any}?, Tags: {string}?}?;
 	for _, parameter in {...} do
 		if typeof(parameter) == "Instance" then
 			if parent then error("Parent parameter used more than once") end
@@ -93,19 +93,20 @@ function New.Instance(className: string, ...: any?): any
 	return newInstance
 end
 
---- Clones and returns and Instance.
+--- Clones and returns an Instance.
 --- @param instance -- The Instance to clone from.
 --- @param parent? -- The Parent for the cloned Instance after creation.
 --- @param name? -- The Name for the cloned Instance.
 --- @param properties? -- A table of properties to apply to the cloned Instance.
 --- @return Instance -- The cloned Instance.
+--- @error Attempt to clone non-Instance -- Incorrect usage.
 --- @error Parent parameter used more than once -- Incorrect usage.
 --- @error Name parameter used more than once -- Incorrect usage.
 --- @error Properties parameter used more than once -- Incorrect usage.
-function New.Clone<T>(instance: T, ...: any?): T
+function New.Clone<T>(instance: T, ...: (Instance | string | {[string]: any, Children: {Instance}?, Attributes: {[string]: any}?, Tags: {string}?})?): T
 	assert(typeof(instance) == "Instance", "Attempt to clone non-Instance")
 
-	local parent: Instance?, name: string?, properties: {[string]: any, Children: {Instance}?}?
+	local parent: Instance?, name: string?, properties: {[string]: any, Children: {Instance}?, Attributes: {[string]: any}?, Tags: {string}?}?;
 	for _, parameter in {...} do
 		if typeof(parameter) == "Instance" then
 			if parent then error("Parent parameter used more than once") end

diff --git a/Pronghorn/init.lua b/Pronghorn/init.lua
@@ -29,7 +29,7 @@
 ║                           ██████▀██▓▌▀▌ ▄     ▄▓▌▐▓█▌                ║
 ║                                                                      ║
 ║                                                                      ║
-║                    Pronghorn Framework  Rev. B49                     ║
+║                    Pronghorn Framework  Rev. B50                     ║
 ║             https://github.com/Iron-Stag-Games/Pronghorn             ║
 ║                GNU Lesser General Public License v2.1                ║
 ║                                                                      ║