Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create team member component #29

Closed
wants to merge 3 commits into from
Closed

Conversation

randa9yahya
Copy link
Collaborator

@randa9yahya randa9yahya commented Aug 7, 2020

team member done
fixes #13

@wisammechano wisammechano requested a review from osamaakb August 10, 2020 17:52
@wisammechano wisammechano changed the title Randa9yahya/issue13 create team member component Aug 10, 2020
Copy link
Collaborator

@osamaakb osamaakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run yarn run fix and yarn run lint before staging

@@ -0,0 +1,39 @@
import React, { useEffect } from 'react';
import AOS from 'aos';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add AOS to the dependencies in package.json

@@ -7819,6 +7819,42 @@ video {
-webkit-overflow-scrolling: auto;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes should be applied to this file

@osamaakb
Copy link
Collaborator

also, please don't fork this repo, create a branch in this repo and put your code in there

@@ -6,3 +6,45 @@
/* Override utils here*/

@tailwind utilities;
.aboutus{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't have css classes not related to tailwind

@osamaakb osamaakb closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create team member component
2 participants