This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Allow custom regex via "vhp-ban-regex" query parameter #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My approach for #96.
Similar to query parameter
vhp-regex
, you can now add a custom regex using the query parametervhp-ban-regex
to thepurge_urls
.If it is set, the
PURGE
request contains an additional headerX-Ban-Regex
and theX-Purge-Method
isban-regex
.If the VCL contains this functionality (described below), it will be used. Otherwise – to preserve backwards compatibility – only the request url itself is purged.
The VCL now looks like this:
What I don't like in this approach is that
X-Purge-Method: regex
andX-Purge-Method: ban-regex
as well as$pregex
and$bregex
might be confusing (but is needed for backwards compatibility or for people who cannot change their VCL).