Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract KES period info check to function #2747

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Extract KES period info check to function #2747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcde18b
refactor(tests): extract KES period info check to function
mkoura Nov 11, 2024
90c979b
fix(tests): fix docstring for expired KES test
mkoura Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 52 additions & 41 deletions cardano_node_tests/tests/test_kes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ def test_expired_kes(
):
"""Test expired KES.

* start local cluster instance configured with short KES period and low number of key
evolutions, so KES expires soon on all pools
* refresh opcert on 2 of the 3 pools, so KES doesn't expire on those 2 pools and
the pools keep minting blocks
Expand All @@ -155,7 +156,6 @@ def test_expired_kes(
"""
# pylint: disable=too-many-statements,too-many-locals
cluster = cluster_kes
kes_period_info_errors_list = []
temp_template = common.get_test_id(cluster)

expire_slot = KES_EXPIRE_SLOT + 100
Expand Down Expand Up @@ -217,6 +217,49 @@ def _refresh_opcerts() -> tp.Dict[str, int]:
cluster_nodes.restart_all_nodes(delay=5)
return refreshed_nodes_kes_period

def _check_kes_period_info(
refreshed_nodes_kes_period: tp.Dict[str, int],
) -> tp.List[str]:
errors = []
# Check kes-period-info with an operational certificate with KES expired
kes_info_expired = cluster.g_query.get_kes_period_info(
opcert_file=expire_pool_rec["pool_operational_cert"]
)
with open(f"{temp_template}_kes_period_info_1.json", "w", encoding="utf-8") as out_fp:
json.dump(kes_info_expired, out_fp, indent=2)
errors.extend(
kes.check_kes_period_info_result(
cluster_obj=cluster,
kes_output=kes_info_expired,
expected_scenario=kes.KesScenarios.INVALID_KES_PERIOD,
check_id="1",
pool_num=expire_pool_num,
)
)

# Check kes-period-info with valid operational certificates
for idx, n in enumerate(refreshed_nodes):
refreshed_pool_rec = cluster_manager.cache.addrs_data[f"node-{n}"]
kes_info_valid = cluster.g_query.get_kes_period_info(
opcert_file=refreshed_pool_rec["pool_operational_cert"]
)
check_id = str(2 + idx)
with open(
f"{temp_template}_kes_period_info_{check_id}.json", "w", encoding="utf-8"
) as out_fp:
json.dump(kes_info_valid, out_fp, indent=2)
errors.extend(
kes.check_kes_period_info_result(
cluster_obj=cluster,
kes_output=kes_info_valid,
expected_scenario=kes.KesScenarios.ALL_VALID,
check_id=check_id,
expected_start_kes=refreshed_nodes_kes_period[n],
)
)

return errors

this_epoch = cluster.g_query.get_epoch()
clusterlib_utils.save_ledger_state(
cluster_obj=cluster,
Expand Down Expand Up @@ -284,54 +327,22 @@ def _refresh_opcerts() -> tp.Dict[str, int]:
not is_minting
), f"The pool '{expire_pool_name}' has minted blocks in epoch {this_epoch}"

# Refresh opcerts on pools that are not supposed to expire one more time
# Refresh opcerts one more time on pools that are not supposed to expire
refreshed_nodes_kes_period = _refresh_opcerts()

LOGGER.info(
f"{datetime.datetime.now(tz=datetime.timezone.utc)}: "
"Waiting 120 secs to make sure the expected errors make it to log files."
)
time.sleep(120)

this_epoch = cluster.g_query.get_epoch()
_save_all_metrics(temp_template=f"{temp_template}_{this_epoch}_after_refresh")
_save_all_period_info(temp_template=f"{temp_template}_{this_epoch}_after_refresh")

# Check kes-period-info with an operational certificate with KES expired
kes_info_expired = cluster.g_query.get_kes_period_info(
opcert_file=expire_pool_rec["pool_operational_cert"]
)
with open(f"{temp_template}_kes_period_info_1.json", "w", encoding="utf-8") as out_fp:
json.dump(kes_info_expired, out_fp, indent=2)
kes_period_info_errors_list.extend(
kes.check_kes_period_info_result(
cluster_obj=cluster,
kes_output=kes_info_expired,
expected_scenario=kes.KesScenarios.INVALID_KES_PERIOD,
check_id="1",
pool_num=expire_pool_num,
kes_period_info_errors_list = _check_kes_period_info(
refreshed_nodes_kes_period=refreshed_nodes_kes_period
)
)

# Check kes-period-info with valid operational certificates
for idx, n in enumerate(refreshed_nodes):
refreshed_pool_rec = cluster_manager.cache.addrs_data[f"node-{n}"]
kes_info_valid = cluster.g_query.get_kes_period_info(
opcert_file=refreshed_pool_rec["pool_operational_cert"]
)
check_id = str(2 + idx)
with open(
f"{temp_template}_kes_period_info_{check_id}.json", "w", encoding="utf-8"
) as out_fp:
json.dump(kes_info_valid, out_fp, indent=2)
kes_period_info_errors_list.extend(
kes.check_kes_period_info_result(
cluster_obj=cluster,
kes_output=kes_info_valid,
expected_scenario=kes.KesScenarios.ALL_VALID,
check_id=check_id,
expected_start_kes=refreshed_nodes_kes_period[n],
)
LOGGER.info(
f"{datetime.datetime.now(tz=datetime.timezone.utc)}: "
"Waiting 90 secs to make sure the expected errors make it to log files."
)
time.sleep(90)

kes.finish_on_errors(errors=kes_period_info_errors_list)

Expand Down
Loading