Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): remove redundant SKIPIF_NOT_HF_SHORTCUT #2728

Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor(tests): remove redundant SKIPIF_NOT_HF_SHORTCUT #2728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions cardano_node_tests/tests/test_kes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@

pytestmark = common.SKIPIF_WRONG_ERA

# TODO: It would be better to use `cluster_nodes.get_cluster_type().uses_shortcut`, but we would
# need to get a cluster instance first. That would be too expensive in this module, as we are using
# custom startup scripts.
SKIPIF_NOT_HF_SHORTCUT = pytest.mark.skipif(
"_fast" not in configuration.SCRIPTS_DIRNAME,
reason="Runs only on local cluster with HF shortcut.",
)

# Slot number where KES certificate expires when using `cluster_kes`
KES_EXPIRE_SLOT = 2100

Expand Down Expand Up @@ -134,10 +126,14 @@ def _check_block_production(
class TestKES:
"""Basic tests for KES period."""

MAX_INT_VAL = 2**64

@allure.link(helpers.get_vcs_link())
@SKIPIF_NOT_HF_SHORTCUT
# It would be better to use `cluster_nodes.get_cluster_type().uses_shortcut`, but we
# would need to get a cluster instance first. That would be too expensive in this test,
# as we are using custom startup scripts.
@pytest.mark.skipif(
"_fast" not in configuration.SCRIPTS_DIRNAME,
reason="Runs only on local cluster with HF shortcut.",
)
@pytest.mark.order(5)
@pytest.mark.long
def test_expired_kes(
Expand All @@ -148,7 +144,6 @@ def test_expired_kes(
):
"""Test expired KES.

* start local cluster instance configured with short KES period and low number of key
evolutions, so KES expires soon on all pools
* refresh opcert on 2 of the 3 pools, so KES doesn't expire on those 2 pools and
the pools keep minting blocks
Expand Down
Loading