Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #4445 #4454

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Follow up to #4445 #4454

merged 4 commits into from
Jul 2, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Jul 1, 2024

Description

Relates to #4445

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky marked this pull request as draft July 1, 2024 15:18
@Lucsanszky Lucsanszky force-pushed the ldan/add-missing-changelog-entries branch 4 times, most recently from 22a92d3 to 6dd41d3 Compare July 2, 2024 16:55
@Lucsanszky Lucsanszky marked this pull request as ready for review July 2, 2024 19:16
@Lucsanszky Lucsanszky changed the title Update CHANGELOGs Follow up to #4445 Jul 2, 2024
@Lucsanszky Lucsanszky force-pushed the ldan/add-missing-changelog-entries branch 3 times, most recently from b1cd693 to c96d9db Compare July 2, 2024 19:48
@Lucsanszky Lucsanszky force-pushed the ldan/add-missing-changelog-entries branch from c96d9db to 1bc6aae Compare July 2, 2024 19:48
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@lehins lehins enabled auto-merge July 2, 2024 20:00
@lehins lehins merged commit df075e1 into master Jul 2, 2024
122 of 126 checks passed
@lehins lehins deleted the ldan/add-missing-changelog-entries branch July 2, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants