Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOGs #4332

Merged
merged 1 commit into from
May 15, 2024
Merged

Update CHANGELOGs #4332

merged 1 commit into from
May 15, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented May 10, 2024

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think that after we release cardano-ledger-babbage-test 1.2.0.2 and cardano-ledger-conway-test 1.2.1.5, after your other PR gets merged, we also need to add a changelog entry for their corresponding cabal files

@Lucsanszky
Copy link
Contributor Author

Lucsanszky commented May 13, 2024

Looks good to me, but I think that after we release cardano-ledger-babbage-test 1.2.0.2 and cardano-ledger-conway-test 1.2.1.5, after your other PR gets merged, we also need to add a changelog entry for their corresponding cabal files

Will do! As soon as the CHaP release is done and I pushed the tags here. Until then, I'll mark this as draft. Thanks! Done.

@Lucsanszky Lucsanszky marked this pull request as draft May 13, 2024 14:17
@Lucsanszky Lucsanszky marked this pull request as ready for review May 13, 2024 19:57
@Lucsanszky Lucsanszky enabled auto-merge May 15, 2024 00:57
@Lucsanszky Lucsanszky merged commit 5ed6890 into master May 15, 2024
125 checks passed
@Lucsanszky Lucsanszky deleted the ldan/update-changelogs branch May 15, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants