Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal deposits to DRep active voting stake. #4309

Merged
merged 6 commits into from
May 7, 2024

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Apr 30, 2024

Description

Add proposal-deposits to the DRep distribution.

Partially addresses #4061. The same will be implemented for SPOs in a follow-up.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/proposal-deposits-in-voting-stake branch from 2e294a1 to de29d09 Compare May 1, 2024 01:19
@aniketd aniketd force-pushed the aniketd/proposal-deposits-in-voting-stake branch from de29d09 to e27f1c4 Compare May 3, 2024 14:15
@aniketd aniketd force-pushed the aniketd/proposal-deposits-in-voting-stake branch from ec7d9d5 to aed8c7c Compare May 6, 2024 10:22
@lehins lehins force-pushed the aniketd/proposal-deposits-in-voting-stake branch from 8da2c5f to 4c6a173 Compare May 6, 2024 23:36
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@lehins lehins enabled auto-merge May 6, 2024 23:43
@lehins lehins merged commit 63ddaf6 into master May 7, 2024
125 checks passed
@lehins lehins deleted the aniketd/proposal-deposits-in-voting-stake branch May 7, 2024 01:15
@aniketd aniketd mentioned this pull request May 7, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants