-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal deposits to DRep active voting stake. #4309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/proposal-deposits-in-voting-stake
branch
from
May 1, 2024 01:19
2e294a1
to
de29d09
Compare
teodanciu
reviewed
May 1, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
May 1, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
May 1, 2024
teodanciu
reviewed
May 1, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
May 1, 2024
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/RatifySpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
May 1, 2024
teodanciu
reviewed
May 1, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
May 2, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
May 2, 2024
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/DRepPulser.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/proposal-deposits-in-voting-stake
branch
from
May 3, 2024 14:15
de29d09
to
e27f1c4
Compare
aniketd
force-pushed
the
aniketd/proposal-deposits-in-voting-stake
branch
from
May 6, 2024 10:22
ec7d9d5
to
aed8c7c
Compare
Also add imptests.
field to the DRepPulser to memoize a `Map` from staking credentials to total proposal deposits made by that credential.
lehins
force-pushed
the
aniketd/proposal-deposits-in-voting-stake
branch
from
May 6, 2024 23:36
8da2c5f
to
4c6a173
Compare
lehins
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add proposal-deposits to the DRep distribution.
Partially addresses #4061. The same will be implemented for SPOs in a follow-up.
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)